iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bluetooth: RFCOMM: Use DEVICE_ATTR_RO macro

Browse Source 
Use DEVICE_ATTR_RO helper instead of plain DEVICE_ATTR,
which makes the code a bit shorter and easier to read.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
This commit is contained in:
YueHaibing 2021-05-20 21:32:35 +08:00 committed by Marcel Holtmann
parent e848dbd364
commit c615943ef0
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
net/bluetooth/rfcomm/tty.c
View File

@ -198,20 +198,22 @@ static void rfcomm_reparent_device(struct rfcomm_dev *dev)
hci_dev_put(hdev); hci_dev_put(hdev);
} }
static ssize_t show_address(struct device *tty_dev, struct device_attribute *attr, char *buf) static ssize_t address_show(struct device *tty_dev,
struct device_attribute *attr, char *buf)
{ {
struct rfcomm_dev *dev = dev_get_drvdata(tty_dev); struct rfcomm_dev *dev = dev_get_drvdata(tty_dev);
return sprintf(buf, "%pMR\n", &dev->dst); return sprintf(buf, "%pMR\n", &dev->dst);
} }
static ssize_t show_channel(struct device *tty_dev, struct device_attribute *attr, char *buf) static ssize_t channel_show(struct device *tty_dev,
struct device_attribute *attr, char *buf)
{ {
struct rfcomm_dev *dev = dev_get_drvdata(tty_dev); struct rfcomm_dev *dev = dev_get_drvdata(tty_dev);
return sprintf(buf, "%d\n", dev->channel); return sprintf(buf, "%d\n", dev->channel);
} }
static DEVICE_ATTR(address, 0444, show_address, NULL); static DEVICE_ATTR_RO(address);
static DEVICE_ATTR(channel, 0444, show_channel, NULL); static DEVICE_ATTR_RO(channel);
static struct rfcomm_dev *__rfcomm_dev_add(struct rfcomm_dev_req *req, static struct rfcomm_dev *__rfcomm_dev_add(struct rfcomm_dev_req *req,
struct rfcomm_dlc *dlc) struct rfcomm_dlc *dlc)