iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "SUNRPC: clean up integer overflow check"

Browse Source 
This reverts commit e87cf8a28e.

This commit was added to silence a tautological comparison warning, but
removing the 'len' value check before calling xdr_inline_decode() is
really not what we want.

Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
This commit is contained in:
Anna Schumaker
2023-09-15 15:46:08 -04:00
parent 4506f23e11
commit c656a4d548
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
include/linux/sunrpc/xdr.h
View File

@ -779,7 +779,9 @@ xdr_stream_decode_uint32_array(struct xdr_stream *xdr,
if (unlikely(xdr_stream_decode_u32(xdr, &len) < 0)) if (unlikely(xdr_stream_decode_u32(xdr, &len) < 0))
return -EBADMSG; return -EBADMSG;
p = xdr_inline_decode(xdr, size_mul(len, sizeof(*p))); if (len > SIZE_MAX / sizeof(*p))
return -EBADMSG;
p = xdr_inline_decode(xdr, len * sizeof(*p));
if (unlikely(!p)) if (unlikely(!p))
return -EBADMSG; return -EBADMSG;
if (array == NULL) if (array == NULL)