iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[media] wl12xx: g_volatile_ctrl fix: wrong field set

Browse Source 
The function g_volatile_ctrl should change the current value rather than the
new value. These two drivers didn't do that, so the value is never reported
correctly.

In the future this will change since this behavior is clearly unexpected,
but for now fix these drivers first.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Hans Verkuil 2011-05-05 04:37:28 -03:00 committed by Mauro Carvalho Chehab
parent c9d5d7790c
commit c6ae804a65
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/media/radio/radio-wl1273.c
View File

@ -1382,7 +1382,7 @@ static int wl1273_fm_g_volatile_ctrl(struct v4l2_ctrl *ctrl)
switch (ctrl->id) { switch (ctrl->id) {
case V4L2_CID_TUNE_ANTENNA_CAPACITOR: case V4L2_CID_TUNE_ANTENNA_CAPACITOR:
ctrl->val = wl1273_fm_get_tx_ctune(radio); ctrl->cur.val = wl1273_fm_get_tx_ctune(radio);
break; break;
default: default:

2
drivers/media/radio/wl128x/fmdrv_v4l2.c
View File

@ -191,7 +191,7 @@ static int fm_g_volatile_ctrl(struct v4l2_ctrl *ctrl)
switch (ctrl->id) { switch (ctrl->id) {
case V4L2_CID_TUNE_ANTENNA_CAPACITOR: case V4L2_CID_TUNE_ANTENNA_CAPACITOR:
ctrl->val = fm_tx_get_tune_cap_val(fmdev); ctrl->cur.val = fm_tx_get_tune_cap_val(fmdev);
break; break;
default: default:
fmwarn("%s: Unknown IOCTL: %d\n", __func__, ctrl->id); fmwarn("%s: Unknown IOCTL: %d\n", __func__, ctrl->id);