iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

greybus: connection: drop the connection_mutex

Browse Source 
Drop the useless connection_mutex that did not, and can not be used to
prevent connection lookup races in atomic context and therefore serves
no purpose.

Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
This commit is contained in:
Johan Hovold 2016-01-19 12:51:24 +01:00 committed by Greg Kroah-Hartman
parent c3681f6c92
commit c6d64a19cd
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/staging/greybus/connection.c
View File

@ -66,8 +66,6 @@ void greybus_data_rcvd(struct gb_host_device *hd, u16 cport_id,
}
EXPORT_SYMBOL_GPL(greybus_data_rcvd);
static DEFINE_MUTEX(connection_mutex);
static void gb_connection_kref_release(struct kref *kref)
{
struct gb_connection *connection;
@ -75,7 +73,6 @@ static void gb_connection_kref_release(struct kref *kref)
connection = container_of(kref, struct gb_connection, kref);
kfree(connection);
mutex_unlock(&connection_mutex);
}
static void gb_connection_init_name(struct gb_connection *connection)
@ -519,8 +516,7 @@ void gb_connection_destroy(struct gb_connection *connection)
ida_simple_remove(id_map, connection->hd_cport_id);
connection->hd_cport_id = CPORT_ID_BAD;
kref_put_mutex(&connection->kref, gb_connection_kref_release,
&connection_mutex);
kref_put(&connection->kref, gb_connection_kref_release);
}
void gb_connection_latency_tag_enable(struct gb_connection *connection)