iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[S390] Cleanup cio printk messages.

Browse Source 
Unnecessary dev_info, dev_warn and printk messages are removed.

Signed-off-by: Michael Ernst <mernst@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
This commit is contained in:
Michael Ernst 2008-07-14 09:59:22 +02:00 committed by Heiko Carstens
parent 23d1742179
commit c78aa6cbac
4 changed files with 11 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/s390/cio/chp.c
View File

@ -123,11 +123,8 @@ static int s390_vary_chpid(struct chp_id chpid, int on)
CIO_TRACE_EVENT(2, dbf_text); CIO_TRACE_EVENT(2, dbf_text);
status = chp_get_status(chpid); status = chp_get_status(chpid);
if (!on && !status) { if (!on && !status)
printk(KERN_ERR "cio: chpid %x.%02x is already offline\n", return 0;
chpid.cssid, chpid.id);
return -EINVAL;
}
set_chp_logically_online(chpid, on); set_chp_logically_online(chpid, on);
chsc_chp_vary(chpid, on); chsc_chp_vary(chpid, on);

3
drivers/s390/cio/cio.c
View File

@ -74,7 +74,6 @@ out_unregister:
debug_unregister(cio_debug_trace_id); debug_unregister(cio_debug_trace_id);
if (cio_debug_crw_id) if (cio_debug_crw_id)
debug_unregister(cio_debug_crw_id); debug_unregister(cio_debug_crw_id);
printk(KERN_WARNING"cio: could not initialize debugging\n");
return -1; return -1;
} }
@ -755,7 +754,6 @@ cio_get_console_sch_no(void)
/* unlike in 2.4, we cannot autoprobe here, since /* unlike in 2.4, we cannot autoprobe here, since
* the channel subsystem is not fully initialized. * the channel subsystem is not fully initialized.
* With some luck, the HWC console can take over */ * With some luck, the HWC console can take over */
printk(KERN_WARNING "cio: No ccw console found!\n");
return -1; return -1;
} }
return console_irq; return console_irq;
@ -772,6 +770,7 @@ cio_probe_console(void)
sch_no = cio_get_console_sch_no(); sch_no = cio_get_console_sch_no();
if (sch_no == -1) { if (sch_no == -1) {
console_subchannel_in_use = 0; console_subchannel_in_use = 0;
printk(KERN_WARNING "cio: No ccw console found!\n");
return ERR_PTR(-ENODEV); return ERR_PTR(-ENODEV);
} }
memset(&console_subchannel, 0, sizeof(struct subchannel)); memset(&console_subchannel, 0, sizeof(struct subchannel));

9
drivers/s390/cio/cmf.c
View File

@ -612,9 +612,6 @@ static int alloc_cmb(struct ccw_device *cdev)
free_pages((unsigned long)mem, get_order(size)); free_pages((unsigned long)mem, get_order(size));
} else if (!mem) { } else if (!mem) {
/* no luck */ /* no luck */
printk(KERN_WARNING "cio: failed to allocate area "
"for measuring %d subchannels\n",
cmb_area.num_channels);
ret = -ENOMEM; ret = -ENOMEM;
goto out; goto out;
} else { } else {
@ -1230,13 +1227,9 @@ static ssize_t cmb_enable_store(struct device *dev,
switch (val) { switch (val) {
case 0: case 0:
ret = disable_cmf(cdev); ret = disable_cmf(cdev);
if (ret)
dev_info(&cdev->dev, "disable_cmf failed (%d)\n", ret);
break; break;
case 1: case 1:
ret = enable_cmf(cdev); ret = enable_cmf(cdev);
if (ret && ret != -EBUSY)
dev_info(&cdev->dev, "enable_cmf failed (%d)\n", ret);
break; break;
} }
@ -1364,8 +1357,6 @@ static int __init init_cmf(void)
cmbops = &cmbops_extended; cmbops = &cmbops_extended;
break; break;
default: default:
printk(KERN_ERR "cio: Invalid format %d for channel "
"measurement facility\n", format);
return 1; return 1;
} }

18
drivers/s390/cio/device.c
View File

@ -493,25 +493,22 @@ static int online_store_recog_and_online(struct ccw_device *cdev)
ccw_device_set_online(cdev); ccw_device_set_online(cdev);
return 0; return 0;
} }
static void online_store_handle_online(struct ccw_device *cdev, int force) static int online_store_handle_online(struct ccw_device *cdev, int force)
{ {
int ret; int ret;
ret = online_store_recog_and_online(cdev); ret = online_store_recog_and_online(cdev);
if (ret) if (ret)
return; return ret;
if (force && cdev->private->state == DEV_STATE_BOXED) { if (force && cdev->private->state == DEV_STATE_BOXED) {
ret = ccw_device_stlck(cdev); ret = ccw_device_stlck(cdev);
if (ret) { if (ret)
dev_warn(&cdev->dev, return ret;
"ccw_device_stlck returned %d!\n", ret);
return;
}
if (cdev->id.cu_type == 0) if (cdev->id.cu_type == 0)
cdev->private->state = DEV_STATE_NOT_OPER; cdev->private->state = DEV_STATE_NOT_OPER;
online_store_recog_and_online(cdev); online_store_recog_and_online(cdev);
} }
return 0;
} }
static ssize_t online_store (struct device *dev, struct device_attribute *attr, static ssize_t online_store (struct device *dev, struct device_attribute *attr,
@ -544,8 +541,9 @@ static ssize_t online_store (struct device *dev, struct device_attribute *attr,
ret = count; ret = count;
break; break;
case 1: case 1:
online_store_handle_online(cdev, force); ret = online_store_handle_online(cdev, force);
ret = count; if (!ret)
ret = count;
break; break;
default: default:
ret = -EINVAL; ret = -EINVAL;