iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

USB: yurex: fix race between probe() and read()

Browse Source 
There's a window during which read() would return 0 instead
of a correct error for no data yet. Reorder initialization
to fix the race.

Signed-off-by: Oliver Neukum <oneukum@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Oliver Neukum 2014-05-19 13:52:20 +02:00 committed by Greg Kroah-Hartman
parent 552e1f2679
commit c78d1ecfd7
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/usb/misc/yurex.c
View File

@ -296,6 +296,7 @@ static int yurex_probe(struct usb_interface *interface, const struct usb_device_
/* save our data pointer in this interface device */ /* save our data pointer in this interface device */
usb_set_intfdata(interface, dev); usb_set_intfdata(interface, dev);
dev->bbu = -1;
/* we can register the device now, as it is ready */ /* we can register the device now, as it is ready */
retval = usb_register_dev(interface, &yurex_class); retval = usb_register_dev(interface, &yurex_class);
@ -306,8 +307,6 @@ static int yurex_probe(struct usb_interface *interface, const struct usb_device_
goto error; goto error;
} }
dev->bbu = -1;
dev_info(&interface->dev, dev_info(&interface->dev,
"USB YUREX device now attached to Yurex #%d\n", "USB YUREX device now attached to Yurex #%d\n",
interface->minor); interface->minor);