iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

raid5-ppl: stop using bio_devname

Browse Source 
Use the %pg format specifier to save on stack consuption and code size.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: Song Liu <song@kernel.org>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Link: https://lore.kernel.org/r/20220304180105.409765-9-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
Christoph Hellwig 2022-03-04 19:01:03 +01:00 committed by Jens Axboe
parent ac483eb375
commit c7dec4623c
1 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/md/raid5-ppl.c
View File

@ -416,12 +416,10 @@ static void ppl_log_endio(struct bio *bio)
static void ppl_submit_iounit_bio(struct ppl_io_unit *io, struct bio *bio) static void ppl_submit_iounit_bio(struct ppl_io_unit *io, struct bio *bio)
{ {
char b[BDEVNAME_SIZE]; pr_debug("%s: seq: %llu size: %u sector: %llu dev: %pg\n",
pr_debug("%s: seq: %llu size: %u sector: %llu dev: %s\n",
__func__, io->seq, bio->bi_iter.bi_size, __func__, io->seq, bio->bi_iter.bi_size,
(unsigned long long)bio->bi_iter.bi_sector, (unsigned long long)bio->bi_iter.bi_sector,
bio_devname(bio, b)); bio->bi_bdev);
submit_bio(bio); submit_bio(bio);
} }
@ -589,9 +587,8 @@ static void ppl_flush_endio(struct bio *bio)
struct ppl_log *log = io->log; struct ppl_log *log = io->log;
struct ppl_conf *ppl_conf = log->ppl_conf; struct ppl_conf *ppl_conf = log->ppl_conf;
struct r5conf *conf = ppl_conf->mddev->private; struct r5conf *conf = ppl_conf->mddev->private;
char b[BDEVNAME_SIZE];
pr_debug("%s: dev: %s\n", __func__, bio_devname(bio, b)); pr_debug("%s: dev: %pg\n", __func__, bio->bi_bdev);
if (bio->bi_status) { if (bio->bi_status) {
struct md_rdev *rdev; struct md_rdev *rdev;
@ -634,7 +631,6 @@ static void ppl_do_flush(struct ppl_io_unit *io)
if (bdev) { if (bdev) {
struct bio *bio; struct bio *bio;
char b[BDEVNAME_SIZE];
bio = bio_alloc_bioset(bdev, 0, GFP_NOIO, bio = bio_alloc_bioset(bdev, 0, GFP_NOIO,
REQ_OP_WRITE | REQ_PREFLUSH, REQ_OP_WRITE | REQ_PREFLUSH,
@ -642,8 +638,7 @@ static void ppl_do_flush(struct ppl_io_unit *io)
bio->bi_private = io; bio->bi_private = io;
bio->bi_end_io = ppl_flush_endio; bio->bi_end_io = ppl_flush_endio;
pr_debug("%s: dev: %s\n", __func__, pr_debug("%s: dev: %ps\n", __func__, bio->bi_bdev);
bio_devname(bio, b));
submit_bio(bio); submit_bio(bio);
flushed_disks++; flushed_disks++;