iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix a bad error case handling in read_cache_page_async()

Browse Source 
Commit 6fe6900e1e introduced a nasty bug
in read_cache_page_async().

It added a "mark_page_accessed(page)" at the final return path in
read_cache_page_async().  But in error cases, 'page' holds the error
code, and you can't mark it accessed.

[ and Glauber de Oliveira Costa points out that we can use a return
  instead of adding more goto's ]

Signed-off-by: David Howells <dhowells@redhat.com>
Acked-by: Nick Piggin <npiggin@suse.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
David Howells 2007-05-09 13:42:20 +01:00 committed by Linus Torvalds
parent aabded9c3a
commit c855ff3718
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
mm/filemap.c
View File

@ -1784,7 +1784,7 @@ struct page *read_cache_page_async(struct address_space *mapping,
retry:
page = __read_cache_page(mapping, index, filler, data);
if (IS_ERR(page))
goto out;
return page;
mark_page_accessed(page);
if (PageUptodate(page))
goto out;
@ -1802,7 +1802,7 @@ retry:
err = filler(data, page);
if (err < 0) {
page_cache_release(page);
page = ERR_PTR(err);
return ERR_PTR(err);
}
out:
mark_page_accessed(page);