iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

selinux: fix memleak in security_read_state_kernel()

Browse Source 
[ Upstream commit 73de1befcc53a7c68b0c5e76b9b5ac41c517760f ]

In this function, it directly returns the result of __security_read_policy
without freeing the allocated memory in *data, cause memory leak issue,
so free the memory if __security_read_policy failed.

Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
[PM: subject line tweak]
Signed-off-by: Paul Moore <paul@paul-moore.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Xiu Jianfeng 2022-06-13 21:59:53 +08:00 committed by Greg Kroah-Hartman
parent 2f0e18e0db
commit c877c52171
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
security/selinux/ss/services.c
View File

@ -4045,6 +4045,7 @@ int security_read_policy(struct selinux_state *state,
int security_read_state_kernel(struct selinux_state *state,
void **data, size_t *len)
{
int err;
struct selinux_policy *policy;
policy = rcu_dereference_protected(
@ -4057,5 +4058,11 @@ int security_read_state_kernel(struct selinux_state *state,
if (!*data)
return -ENOMEM;
return __security_read_policy(policy, *data, len);
err = __security_read_policy(policy, *data, len);
if (err) {
vfree(*data);
*data = NULL;
*len = 0;
}
return err;
}