iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

perf symbols: Fix use-after-free in get_plt_got_name()

Browse Source 
Fix use-after-free in get_plt_got_name().

Discovered using EXTRA_CFLAGS="-fsanitize=undefined -fsanitize=address".

Fixes: ce4c8e7966f317ef ("perf symbols: Get symbols for .plt.got for x86-64")
Reported-by: kernel test robot <yujie.liu@intel.com>
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Acked-by: Ian Rogers <irogers@google.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: https://lore.kernel.org/oe-lkp/202303061424.6ad43294-yujie.liu@intel.com
Link: https://lore.kernel.org/r/20230316194156.8320-2-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Adrian Hunter 2023-03-16 21:41:54 +02:00 committed by Arnaldo Carvalho de Melo
parent 5d9df8731c
commit c8bb2d76a4
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tools/perf/util/symbol-elf.c
View File

@ -557,6 +557,7 @@ static bool get_plt_got_name(GElf_Shdr *shdr, size_t i,
const char *sym_name; const char *sym_name;
char *demangled; char *demangled;
GElf_Sym sym; GElf_Sym sym;
bool result;
u32 disp; u32 disp;
if (!di->sorted) if (!di->sorted)
@ -583,9 +584,11 @@ static bool get_plt_got_name(GElf_Shdr *shdr, size_t i,
snprintf(buf, buf_sz, "%s@plt", sym_name); snprintf(buf, buf_sz, "%s@plt", sym_name);
result = *sym_name;
free(demangled); free(demangled);
return *sym_name; return result;
} }
static int dso__synthesize_plt_got_symbols(struct dso *dso, Elf *elf, static int dso__synthesize_plt_got_symbols(struct dso *dso, Elf *elf,