iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

net: lantiq_etop: Fix return type for implementation of ndo_start_xmit

Browse Source 
Since Linux now supports CFI, it will be a good idea to fix mismatched
return type for implementation of hooks. Otherwise this might get
cought out by CFI and cause a panic.

ltq_etop_tx() would return either NETDEV_TX_BUSY or NETDEV_TX_OK, so
change the return type to netdev_tx_t directly.

Signed-off-by: GUO Zihua <guozihua@huawei.com>
Link: https://lore.kernel.org/r/20220902081521.59867-1-guozihua@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
GUO Zihua 2022-09-02 16:15:21 +08:00 committed by Jakub Kicinski
parent 7b620e1560
commit c8ef3c94bd
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/ethernet/lantiq_etop.c
View File

@ -470,7 +470,7 @@ ltq_etop_stop(struct net_device *dev)
return 0; return 0;
} }
static int static netdev_tx_t
ltq_etop_tx(struct sk_buff *skb, struct net_device *dev) ltq_etop_tx(struct sk_buff *skb, struct net_device *dev)
{ {
int queue = skb_get_queue_mapping(skb); int queue = skb_get_queue_mapping(skb);