iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

gpio/langwell: re-read the IRQ status register after each iteration

Browse Source 
The IRQ status register should be re-read after each iteration.
Otherwise the loop misses the interrupt if it gets raised immediately
after handled.

Reported-by: Grant Likely <grant.likely@secretlab.ca>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
This commit is contained in:
Mika Westerberg 2012-05-10 13:01:22 +03:00 committed by Grant Likely
parent 465f2bd459
commit c8f925b69f
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/gpio/gpio-langwell.c
View File

@ -250,11 +250,9 @@ static void lnw_irq_handler(unsigned irq, struct irq_desc *desc)
/* check GPIO controller to check which pin triggered the interrupt */ /* check GPIO controller to check which pin triggered the interrupt */
for (base = 0; base < lnw->chip.ngpio; base += 32) { for (base = 0; base < lnw->chip.ngpio; base += 32) {
gedr = gpio_reg(&lnw->chip, base, GEDR); gedr = gpio_reg(&lnw->chip, base, GEDR);
pending = readl(gedr); while ((pending = readl(gedr))) {
while (pending) {
gpio = __ffs(pending); gpio = __ffs(pending);
mask = BIT(gpio); mask = BIT(gpio);
pending &= ~mask;
/* Clear before handling so we can't lose an edge */ /* Clear before handling so we can't lose an edge */
writel(mask, gedr); writel(mask, gedr);
generic_handle_irq(irq_find_mapping(lnw->domain, generic_handle_irq(irq_find_mapping(lnw->domain,