iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Btrfs: fix inode leak on failure to setup whiteout inode in rename

Browse Source 
If we failed to fully setup the whiteout inode during a rename operation
with the whiteout flag, we ended up leaking the inode, not decrementing
its link count nor removing all its items from the fs/subvol tree.

Signed-off-by: Filipe Manana <fdmanana@suse.com>
This commit is contained in:
Filipe Manana 2016-05-05 01:41:57 +01:00
parent cdd1fedf82
commit c990161888
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
fs/btrfs/inode.c
View File

@ -9612,21 +9612,21 @@ static int btrfs_whiteout_for_rename(struct btrfs_trans_handle *trans,
ret = btrfs_init_inode_security(trans, inode, dir,
&dentry->d_name);
if (ret)
return ret;
goto out;
ret = btrfs_add_nondir(trans, dir, dentry,
inode, 0, index);
if (ret)
return ret;
goto out;
ret = btrfs_update_inode(trans, root, inode);
if (ret)
return ret;
out:
unlock_new_inode(inode);
if (ret)
inode_dec_link_count(inode);
iput(inode);
return 0;
return ret;
}
static int btrfs_rename(struct inode *old_dir, struct dentry *old_dentry,