iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

regulator: bd71837: Editorial cleanups.

Browse Source 
Address issues spotted by Andy Shevchenko during review of original patch
No functional changes intended

Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Matti Vaittinen 2018-06-28 14:22:23 +03:00 committed by Mark Brown
parent ffdc498410
commit c9dc4cfa10
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
1 changed files with 10 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
drivers/regulator/bd71837-regulator.c
View File

@ -2,19 +2,18 @@
// Copyright (C) 2018 ROHM Semiconductors // Copyright (C) 2018 ROHM Semiconductors
// bd71837-regulator.c ROHM BD71837MWV regulator driver // bd71837-regulator.c ROHM BD71837MWV regulator driver
#include <linux/kernel.h> #include <linux/delay.h>
#include <linux/module.h>
#include <linux/init.h>
#include <linux/err.h> #include <linux/err.h>
#include <linux/gpio.h>
#include <linux/interrupt.h> #include <linux/interrupt.h>
#include <linux/kernel.h>
#include <linux/mfd/bd71837.h>
#include <linux/module.h>
#include <linux/platform_device.h> #include <linux/platform_device.h>
#include <linux/regulator/driver.h> #include <linux/regulator/driver.h>
#include <linux/regulator/machine.h> #include <linux/regulator/machine.h>
#include <linux/delay.h>
#include <linux/slab.h>
#include <linux/gpio.h>
#include <linux/mfd/bd71837.h>
#include <linux/regulator/of_regulator.h> #include <linux/regulator/of_regulator.h>
#include <linux/slab.h>
struct bd71837_pmic { struct bd71837_pmic {
struct regulator_desc descs[BD71837_REGULATOR_CNT]; struct regulator_desc descs[BD71837_REGULATOR_CNT];
@ -39,7 +38,7 @@ static int bd71837_buck1234_set_ramp_delay(struct regulator_dev *rdev,
int id = rdev->desc->id; int id = rdev->desc->id;
unsigned int ramp_value = BUCK_RAMPRATE_10P00MV; unsigned int ramp_value = BUCK_RAMPRATE_10P00MV;
dev_dbg(&(pmic->pdev->dev), "Buck[%d] Set Ramp = %d\n", id + 1, dev_dbg(&pmic->pdev->dev, "Buck[%d] Set Ramp = %d\n", id + 1,
ramp_delay); ramp_delay);
switch (ramp_delay) { switch (ramp_delay) {
case 1 ... 1250: case 1 ... 1250:
@ -544,8 +543,7 @@ static int bd71837_probe(struct platform_device *pdev)
int i, err; int i, err;
pmic = devm_kzalloc(&pdev->dev, sizeof(struct bd71837_pmic), pmic = devm_kzalloc(&pdev->dev, sizeof(*pmic), GFP_KERNEL);
GFP_KERNEL);
if (!pmic) if (!pmic)
return -ENOMEM; return -ENOMEM;
@ -569,8 +567,8 @@ static int bd71837_probe(struct platform_device *pdev)
dev_err(&pmic->pdev->dev, "Failed to unlock PMIC (%d)\n", err); dev_err(&pmic->pdev->dev, "Failed to unlock PMIC (%d)\n", err);
goto err; goto err;
} else { } else {
dev_dbg(&pmic->pdev->dev, "%s: Unlocked lock register 0x%x\n", dev_dbg(&pmic->pdev->dev, "Unlocked lock register 0x%x\n",
__func__, BD71837_REG_REGLOCK); BD71837_REG_REGLOCK);
} }
for (i = 0; i < ARRAY_SIZE(pmic_regulator_inits); i++) { for (i = 0; i < ARRAY_SIZE(pmic_regulator_inits); i++) {
@ -615,8 +613,6 @@ static int bd71837_probe(struct platform_device *pdev)
pmic->rdev[i] = rdev; pmic->rdev[i] = rdev;
} }
return 0;
err: err:
return err; return err;
} }
@ -624,7 +620,6 @@ err:
static struct platform_driver bd71837_regulator = { static struct platform_driver bd71837_regulator = {
.driver = { .driver = {
.name = "bd71837-pmic", .name = "bd71837-pmic",
.owner = THIS_MODULE,
}, },
.probe = bd71837_probe, .probe = bd71837_probe,
}; };