iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

SUNRPC: Fix RPC call retransmission statistics

Browse Source 
A retransmit should be when you successfully transmit an RPC call to
the server a second time.

Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
This commit is contained in:
Trond Myklebust 2013-09-25 13:39:45 -04:00
parent 99875249bf
commit ca7f33aa5b
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
net/sunrpc/clnt.c
View File

@ -1719,6 +1719,8 @@ call_connect_status(struct rpc_task *task)
static void static void
call_transmit(struct rpc_task *task) call_transmit(struct rpc_task *task)
{ {
int is_retrans = RPC_WAS_SENT(task);
dprint_status(task); dprint_status(task);
task->tk_action = call_status; task->tk_action = call_status;
@ -1743,6 +1745,8 @@ call_transmit(struct rpc_task *task)
xprt_transmit(task); xprt_transmit(task);
if (task->tk_status < 0) if (task->tk_status < 0)
return; return;
if (is_retrans)
task->tk_client->cl_stats->rpcretrans++;
/* /*
* On success, ensure that we call xprt_end_transmit() before sleeping * On success, ensure that we call xprt_end_transmit() before sleeping
* in order to allow access to the socket to other RPC requests. * in order to allow access to the socket to other RPC requests.
@ -1983,7 +1987,6 @@ call_timeout(struct rpc_task *task)
rpcauth_invalcred(task); rpcauth_invalcred(task);
retry: retry:
clnt->cl_stats->rpcretrans++;
task->tk_action = call_bind; task->tk_action = call_bind;
task->tk_status = 0; task->tk_status = 0;
} }
@ -2026,7 +2029,6 @@ call_decode(struct rpc_task *task)
if (req->rq_rcv_buf.len < 12) { if (req->rq_rcv_buf.len < 12) {
if (!RPC_IS_SOFT(task)) { if (!RPC_IS_SOFT(task)) {
task->tk_action = call_bind; task->tk_action = call_bind;
clnt->cl_stats->rpcretrans++;
goto out_retry; goto out_retry;
} }
dprintk("RPC: %s: too small RPC reply size (%d bytes)\n", dprintk("RPC: %s: too small RPC reply size (%d bytes)\n",