iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

phy: qcom-qmp-ufs: clean up device-tree parsing

Browse Source 
Since the QMP driver split there will be at most a single child node so
drop the obsolete iteration construct.

While at it, drop the verbose error logging that would have been
printed also on probe deferrals.

Note that there's no need to check if there are additional child nodes
(the kernel is not a devicetree validator), but let's return an error if
there are no child nodes at all for now.

Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20221024090041.19574-4-johan+linaro@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
This commit is contained in:
Johan Hovold
2022-10-24 11:00:34 +02:00
committed by Vinod Koul
parent a36032db30
commit cb2c3d2ee4
1 changed files with 6 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
View File

@@ -1048,7 +1048,6 @@ static int qmp_ufs_probe(struct platform_device *pdev)
void __iomem *serdes; void __iomem *serdes;
const struct qmp_phy_cfg *cfg = NULL; const struct qmp_phy_cfg *cfg = NULL;
struct qmp_ufs *qmp; struct qmp_ufs *qmp;
int num, id;
int ret; int ret;
qmp = devm_kzalloc(dev, sizeof(*qmp), GFP_KERNEL); qmp = devm_kzalloc(dev, sizeof(*qmp), GFP_KERNEL);
@@ -1074,23 +1073,15 @@ static int qmp_ufs_probe(struct platform_device *pdev)
if (ret) if (ret)
return ret; return ret;
num = of_get_available_child_count(dev->of_node); child = of_get_next_available_child(dev->of_node, NULL);
/* do we have a rogue child node ? */ if (!child)
if (num > 1)
return -EINVAL; return -EINVAL;
id = 0; ret = qmp_ufs_create(dev, child, serdes, cfg);
for_each_available_child_of_node(dev->of_node, child) { if (ret)
/* Create per-lane phy */ goto err_node_put;
ret = qmp_ufs_create(dev, child, serdes, cfg);
if (ret) {
dev_err(dev, "failed to create lane%d phy, %d\n",
id, ret);
goto err_node_put;
}
id++; of_node_put(child);
}
phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate); phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);