iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mailbox: handle empty message in tx_tick

Browse Source 
We already check if the message is empty before calling the client
tx_done callback. Calling completion on a wait event is also invalid
if the message is empty.

This patch moves the existing empty message check earlier.

Fixes: 2b6d83e2b8b7 ("mailbox: Introduce framework for mailbox")
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
This commit is contained in:
Sudeep Holla 2017-03-21 11:30:16 +00:00 committed by Jassi Brar
parent cc6eeaa302
commit cb710ab1d8
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/mailbox/mailbox.c
View File

@ -103,8 +103,11 @@ static void tx_tick(struct mbox_chan *chan, int r)
/* Submit next message */ /* Submit next message */
msg_submit(chan); msg_submit(chan);
if (!mssg)
return;
/* Notify the client */ /* Notify the client */
if (mssg && chan->cl->tx_done) if (chan->cl->tx_done)
chan->cl->tx_done(chan->cl, mssg, r); chan->cl->tx_done(chan->cl, mssg, r);
if (r != -ETIME && chan->cl->tx_block) if (r != -ETIME && chan->cl->tx_block)