iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

greybus: uart: add missing serial-state sanity check

Browse Source 
Add dedicated serial-state request handler and add the missing sanity
check on the incoming request.

Reviewed-by: Rui Miguel Silva <rui.silva@linaro.org>
Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
This commit is contained in:
Johan Hovold 2016-02-24 16:11:50 +01:00 committed by Greg Kroah-Hartman
parent 066f950c65
commit cb7f00ba5f
1 changed files with 22 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
drivers/staging/greybus/uart.c
View File

@ -103,13 +103,32 @@ static int gb_uart_receive_data(struct gb_tty *gb_tty,
return 0;
}
static int gb_uart_request_recv(u8 type, struct gb_operation *op)
static int gb_uart_serial_state_handler(struct gb_operation *op)
{
struct gb_connection *connection = op->connection;
struct gb_tty *gb_tty = connection->private;
struct gb_message *request = op->request;
struct gb_uart_serial_state_request *serial_state;
int ret = 0;
if (request->payload_size < sizeof(*serial_state)) {
dev_err(&connection->bundle->dev,
"short serial-state event received (%zu < %zu)\n",
request->payload_size, sizeof(*serial_state));
return -EINVAL;
}
serial_state = request->payload;
gb_tty->ctrlin = serial_state->control;
return 0;
}
static int gb_uart_request_recv(u8 type, struct gb_operation *op)
{
struct gb_connection *connection = op->connection;
struct gb_tty *gb_tty = connection->private;
struct gb_message *request = op->request;
int ret;
switch (type) {
case GB_UART_TYPE_RECEIVE_DATA:
@ -117,8 +136,7 @@ static int gb_uart_request_recv(u8 type, struct gb_operation *op)
request->payload);
break;
case GB_UART_TYPE_SERIAL_STATE:
serial_state = request->payload;
gb_tty->ctrlin = serial_state->control;
ret = gb_uart_serial_state_handler(op);
break;
default:
dev_err(&connection->bundle->dev,