iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

checkpatch: use a more consistent function argument style

Browse Source 
Instead of array indexing $_, use temporary variables like all the other
subroutines in the script use.

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Joe Perches 2014-04-03 14:49:19 -07:00 committed by Linus Torvalds
parent 9b0fa60d9b
commit cbec18afcc
1 changed files with 20 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
scripts/checkpatch.pl
View File

@ -1431,21 +1431,25 @@ sub possible {
my $prefix = ''; my $prefix = '';
sub show_type { sub show_type {
return defined $use_type{$_[0]} if (scalar keys %use_type > 0); my ($type) = @_;
return !defined $ignore_type{$_[0]}; return defined $use_type{$type} if (scalar keys %use_type > 0);
return !defined $ignore_type{$type};
} }
sub report { sub report {
if (!show_type($_[1]) || my ($level, $type, $msg) = @_;
(defined $tst_only && $_[2] !~ /\Q$tst_only\E/)) {
if (!show_type($type) ||
(defined $tst_only && $msg !~ /\Q$tst_only\E/)) {
return 0; return 0;
} }
my $line; my $line;
if ($show_types) { if ($show_types) {
$line = "$prefix$_[0]:$_[1]: $_[2]\n"; $line = "$prefix$level:$type: $msg\n";
} else { } else {
$line = "$prefix$_[0]: $_[2]\n"; $line = "$prefix$level: $msg\n";
} }
$line = (split('\n', $line))[0] . "\n" if ($terse); $line = (split('\n', $line))[0] . "\n" if ($terse);
@ -1453,12 +1457,15 @@ sub report {
return 1; return 1;
} }
sub report_dump { sub report_dump {
our @report; our @report;
} }
sub ERROR { sub ERROR {
if (report("ERROR", $_[0], $_[1])) { my ($type, $msg) = @_;
if (report("ERROR", $type, $msg)) {
our $clean = 0; our $clean = 0;
our $cnt_error++; our $cnt_error++;
return 1; return 1;
@ -1466,7 +1473,9 @@ sub ERROR {
return 0; return 0;
} }
sub WARN { sub WARN {
if (report("WARNING", $_[0], $_[1])) { my ($type, $msg) = @_;
if (report("WARNING", $type, $msg)) {
our $clean = 0; our $clean = 0;
our $cnt_warn++; our $cnt_warn++;
return 1; return 1;
@ -1474,7 +1483,9 @@ sub WARN {
return 0; return 0;
} }
sub CHK { sub CHK {
if ($check && report("CHECK", $_[0], $_[1])) { my ($type, $msg) = @_;
if ($check && report("CHECK", $type, $msg)) {
our $clean = 0; our $clean = 0;
our $cnt_chk++; our $cnt_chk++;
return 1; return 1;