iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bpf: Avoid incorrect -EFAULT error in BPF_LOG_KERNEL mode

Browse Source 
If verifier log is in BPF_LOG_KERNEL mode, no log->ubuf is expected and
it stays NULL throughout entire verification process. Don't erroneously
return -EFAULT in such case.

Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Lorenz Bauer <lmb@isovalent.com>
Link: https://lore.kernel.org/bpf/20230406234205.323208-10-andrii@kernel.org
This commit is contained in:
Andrii Nakryiko 2023-04-06 16:41:55 -07:00 committed by Daniel Borkmann
parent 971fb5057d
commit cbedb42a0d
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
kernel/bpf/verifier.c
View File

@ -18863,7 +18863,7 @@ skip_full_check:
bpf_vlog_finalize(log);
if (log->level && bpf_vlog_truncated(log))
ret = -ENOSPC;
if (log->level && !log->ubuf) {
if (log->level && log->level != BPF_LOG_KERNEL && !log->ubuf) {
ret = -EFAULT;
goto err_release_maps;
}