iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

pinctrl: mediatek: mt8* make driver explicitly non-modular

Browse Source 
The Kconfig for these drivers are currently:

config PINCTRL_MT8127
        bool "Mediatek MT8127 pin control" if COMPILE_TEST && !MACH_MT8127

config PINCTRL_MT8135
        bool "Mediatek MT8135 pin control" if COMPILE_TEST && !MACH_MT8135

config PINCTRL_MT8173
        bool "Mediatek MT8173 pin control"

...meaning that they are currently not being built as a module by anyone.
Lets remove the modular code that is essentially orphaned, so that
when reading the driver there is no doubt it is builtin-only.

A recent commit moved these from module_init to arch_initcall already, so
the init ordering remains untouched with this commit.

We also delete the MODULE_LICENSE tag etc. since all that information
is already contained at the top of the file in the comments.

Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.

Cc: Daniel Kurtz <djkurtz@chromium.org>
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: Hongzhou Yang <hongzhou.yang@mediatek.com>
Cc: Yingjoe Chen <yingjoe.chen@mediatek.com>
Cc: linux-gpio@vger.kernel.org
Cc: linux-mediatek@lists.infradead.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Paul Gortmaker 2016-01-04 12:44:10 -05:00 committed by Linus Walleij
parent aceb16dc2d
commit cc301fd1fc
3 changed files with 3 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/pinctrl/mediatek/pinctrl-mt8127.c
View File

@ -13,7 +13,7 @@
* GNU General Public License for more details. * GNU General Public License for more details.
*/ */
#include <linux/module.h> #include <linux/init.h>
#include <linux/platform_device.h> #include <linux/platform_device.h>
#include <linux/of.h> #include <linux/of.h>
#include <linux/of_device.h> #include <linux/of_device.h>
@ -336,7 +336,6 @@ static const struct of_device_id mt8127_pctrl_match[] = {
{ .compatible = "mediatek,mt8127-pinctrl", }, { .compatible = "mediatek,mt8127-pinctrl", },
{ } { }
}; };
MODULE_DEVICE_TABLE(of, mt8127_pctrl_match);
static struct platform_driver mtk_pinctrl_driver = { static struct platform_driver mtk_pinctrl_driver = {
.probe = mt8127_pinctrl_probe, .probe = mt8127_pinctrl_probe,
@ -350,9 +349,4 @@ static int __init mtk_pinctrl_init(void)
{ {
return platform_driver_register(&mtk_pinctrl_driver); return platform_driver_register(&mtk_pinctrl_driver);
} }
arch_initcall(mtk_pinctrl_init); arch_initcall(mtk_pinctrl_init);
MODULE_LICENSE("GPL v2");
MODULE_DESCRIPTION("MediaTek MT8127 Pinctrl Driver");
MODULE_AUTHOR("Yingjoe Chen <yingjoe.chen@mediatek.com>");

8
drivers/pinctrl/mediatek/pinctrl-mt8135.c
View File

@ -12,7 +12,7 @@
* GNU General Public License for more details. * GNU General Public License for more details.
*/ */
#include <linux/module.h> #include <linux/init.h>
#include <linux/platform_device.h> #include <linux/platform_device.h>
#include <linux/of.h> #include <linux/of.h>
#include <linux/of_device.h> #include <linux/of_device.h>
@ -351,7 +351,6 @@ static const struct of_device_id mt8135_pctrl_match[] = {
}, },
{ } { }
}; };
MODULE_DEVICE_TABLE(of, mt8135_pctrl_match);
static struct platform_driver mtk_pinctrl_driver = { static struct platform_driver mtk_pinctrl_driver = {
.probe = mt8135_pinctrl_probe, .probe = mt8135_pinctrl_probe,
@ -365,9 +364,4 @@ static int __init mtk_pinctrl_init(void)
{ {
return platform_driver_register(&mtk_pinctrl_driver); return platform_driver_register(&mtk_pinctrl_driver);
} }
arch_initcall(mtk_pinctrl_init); arch_initcall(mtk_pinctrl_init);
MODULE_LICENSE("GPL");
MODULE_DESCRIPTION("MediaTek Pinctrl Driver");
MODULE_AUTHOR("Hongzhou Yang <hongzhou.yang@mediatek.com>");

8
drivers/pinctrl/mediatek/pinctrl-mt8173.c
View File

@ -12,7 +12,7 @@
* GNU General Public License for more details. * GNU General Public License for more details.
*/ */
#include <linux/module.h> #include <linux/init.h>
#include <linux/platform_device.h> #include <linux/platform_device.h>
#include <linux/of.h> #include <linux/of.h>
#include <linux/of_device.h> #include <linux/of_device.h>
@ -378,7 +378,6 @@ static const struct of_device_id mt8173_pctrl_match[] = {
}, },
{ } { }
}; };
MODULE_DEVICE_TABLE(of, mt8173_pctrl_match);
static struct platform_driver mtk_pinctrl_driver = { static struct platform_driver mtk_pinctrl_driver = {
.probe = mt8173_pinctrl_probe, .probe = mt8173_pinctrl_probe,
@ -393,9 +392,4 @@ static int __init mtk_pinctrl_init(void)
{ {
return platform_driver_register(&mtk_pinctrl_driver); return platform_driver_register(&mtk_pinctrl_driver);
} }
arch_initcall(mtk_pinctrl_init); arch_initcall(mtk_pinctrl_init);
MODULE_LICENSE("GPL v2");
MODULE_DESCRIPTION("MediaTek Pinctrl Driver");
MODULE_AUTHOR("Hongzhou Yang <hongzhou.yang@mediatek.com>");