iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

staging: iio: tsl2x7x: turn chip off if IIO device registration fails

Browse Source 
This patch turns the chip off if IIO device registration fails so that
the error handling mirrors the device remove to make review easier in
preparation for moving this driver out of staging.

This patch also adds a missing error check in the call to
tsl2x7x_chip_on() in tsl2x7x_probe().

Signed-off-by: Brian Masney <masneyb@onstation.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
This commit is contained in:
Brian Masney 2018-05-10 20:12:17 -04:00 committed by Jonathan Cameron
parent 7b4db2e3e6
commit cc566e90cb
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/staging/iio/light/tsl2x7x.c
View File

@ -1657,10 +1657,13 @@ static int tsl2x7x_probe(struct i2c_client *clientp,
}
tsl2x7x_defaults(chip);
tsl2x7x_chip_on(indio_dev);
ret = tsl2x7x_chip_on(indio_dev);
if (ret < 0)
return ret;
ret = iio_device_register(indio_dev);
if (ret) {
tsl2x7x_chip_off(indio_dev);
dev_err(&clientp->dev,
"%s: iio registration failed\n", __func__);
return ret;