iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

scsi: qla2xxx: Use strlcpy() instead of strncpy()

Browse Source 
This patch fixes several gcc complaints about string truncation.

Cc: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Tested-by: Himanshu Madhani <hmadhani@marvell.com>
Reviewed-by: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Bart Van Assche
2019-08-08 20:01:43 -07:00
committed by Martin K. Petersen
parent 1df627b4f7
commit cc74049f35
1 changed files with 14 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
drivers/scsi/qla2xxx/qla_mr.c
View File

@ -1880,22 +1880,22 @@ qlafx00_fx_disc(scsi_qla_host_t *vha, fc_port_t *fcport, uint16_t fx_type)
phost_info = &preg_hsi->hsi; phost_info = &preg_hsi->hsi;
memset(preg_hsi, 0, sizeof(struct register_host_info)); memset(preg_hsi, 0, sizeof(struct register_host_info));
phost_info->os_type = OS_TYPE_LINUX; phost_info->os_type = OS_TYPE_LINUX;
strncpy(phost_info->sysname, strlcpy(phost_info->sysname, p_sysid->sysname,
p_sysid->sysname, SYSNAME_LENGTH); sizeof(phost_info->sysname));
strncpy(phost_info->nodename, strlcpy(phost_info->nodename, p_sysid->nodename,
p_sysid->nodename, NODENAME_LENGTH); sizeof(phost_info->nodename));
if (!strcmp(phost_info->nodename, "(none)")) if (!strcmp(phost_info->nodename, "(none)"))
ha->mr.host_info_resend = true; ha->mr.host_info_resend = true;
strncpy(phost_info->release, strlcpy(phost_info->release, p_sysid->release,
p_sysid->release, RELEASE_LENGTH); sizeof(phost_info->release));
strncpy(phost_info->version, strlcpy(phost_info->version, p_sysid->version,
p_sysid->version, VERSION_LENGTH); sizeof(phost_info->version));
strncpy(phost_info->machine, strlcpy(phost_info->machine, p_sysid->machine,
p_sysid->machine, MACHINE_LENGTH); sizeof(phost_info->machine));
strncpy(phost_info->domainname, strlcpy(phost_info->domainname, p_sysid->domainname,
p_sysid->domainname, DOMNAME_LENGTH); sizeof(phost_info->domainname));
strncpy(phost_info->hostdriver, strlcpy(phost_info->hostdriver, QLA2XXX_VERSION,
QLA2XXX_VERSION, VERSION_LENGTH); sizeof(phost_info->hostdriver));
preg_hsi->utc = (uint64_t)ktime_get_real_seconds(); preg_hsi->utc = (uint64_t)ktime_get_real_seconds();
ql_dbg(ql_dbg_init, vha, 0x0149, ql_dbg(ql_dbg_init, vha, 0x0149,
"ISP%04X: Host registration with firmware\n", "ISP%04X: Host registration with firmware\n",