iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

leds: spi-byte: Use devm_led_classdev_register_ext()

Browse Source 
Use extended classdev registration to generate generic device names from
color and function enums instead of reading only the label from the
device tree.

Signed-off-by: Stefan Kalscheuer <stefan@stklcode.de>
Link: https://lore.kernel.org/r/20240204150726.29783-1-stefan@stklcode.de
Signed-off-by: Lee Jones <lee@kernel.org>
This commit is contained in:
Stefan Kalscheuer
2024-02-04 16:07:26 +01:00
committed by Lee Jones
parent 46f02b681b
commit ccc35ff2fd
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/leds/leds-spi-byte.c
View File

@ -83,7 +83,7 @@ static int spi_byte_probe(struct spi_device *spi)
struct device_node *child; struct device_node *child;
struct device *dev = &spi->dev; struct device *dev = &spi->dev;
struct spi_byte_led *led; struct spi_byte_led *led;
const char *name = "leds-spi-byte::"; struct led_init_data init_data = {};
const char *state; const char *state;
int ret; int ret;
@ -97,12 +97,9 @@ static int spi_byte_probe(struct spi_device *spi)
if (!led) if (!led)
return -ENOMEM; return -ENOMEM;
of_property_read_string(child, "label", &name);
strscpy(led->name, name, sizeof(led->name));
led->spi = spi; led->spi = spi;
mutex_init(&led->mutex); mutex_init(&led->mutex);
led->cdef = device_get_match_data(dev); led->cdef = device_get_match_data(dev);
led->ldev.name = led->name;
led->ldev.brightness = LED_OFF; led->ldev.brightness = LED_OFF;
led->ldev.max_brightness = led->cdef->max_value - led->cdef->off_value; led->ldev.max_brightness = led->cdef->max_value - led->cdef->off_value;
led->ldev.brightness_set_blocking = spi_byte_brightness_set_blocking; led->ldev.brightness_set_blocking = spi_byte_brightness_set_blocking;
@ -120,7 +117,11 @@ static int spi_byte_probe(struct spi_device *spi)
spi_byte_brightness_set_blocking(&led->ldev, spi_byte_brightness_set_blocking(&led->ldev,
led->ldev.brightness); led->ldev.brightness);
ret = devm_led_classdev_register(&spi->dev, &led->ldev); init_data.fwnode = of_fwnode_handle(child);
init_data.devicename = "leds-spi-byte";
init_data.default_label = ":";
ret = devm_led_classdev_register_ext(&spi->dev, &led->ldev, &init_data);
if (ret) { if (ret) {
mutex_destroy(&led->mutex); mutex_destroy(&led->mutex);
return ret; return ret;