iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tty: hvc-iucv: Make use of iucv_alloc_device()

Browse Source 
Make use of iucv_alloc_device() to get rid of quite some code.

Acked-by: Alexandra Winter <wintera@linux.ibm.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://lore.kernel.org/r/20240506194454.1160315-6-hca@linux.ibm.com
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com>
This commit is contained in:
Heiko Carstens 2024-05-06 21:44:53 +02:00 committed by Alexander Gordeev
parent 3bbde49ec5
commit ccec503229
1 changed files with 2 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
drivers/tty/hvc/hvc_iucv.c
View File

@ -1035,11 +1035,6 @@ static const struct attribute_group *hvc_iucv_dev_attr_groups[] = {
NULL, NULL,
}; };
static void hvc_iucv_free(struct device *data)
{
kfree(data);
}
/** /**
* hvc_iucv_alloc() - Allocates a new struct hvc_iucv_private instance * hvc_iucv_alloc() - Allocates a new struct hvc_iucv_private instance
* @id: hvc_iucv_table index * @id: hvc_iucv_table index
@ -1090,18 +1085,12 @@ static int __init hvc_iucv_alloc(int id, unsigned int is_console)
memcpy(priv->srv_name, name, 8); memcpy(priv->srv_name, name, 8);
ASCEBC(priv->srv_name, 8); ASCEBC(priv->srv_name, 8);
/* create and setup device */ priv->dev = iucv_alloc_device(hvc_iucv_dev_attr_groups, NULL,
priv->dev = kzalloc(sizeof(*priv->dev), GFP_KERNEL); priv, "hvc_iucv%d", id);
if (!priv->dev) { if (!priv->dev) {
rc = -ENOMEM; rc = -ENOMEM;
goto out_error_dev; goto out_error_dev;
} }
dev_set_name(priv->dev, "hvc_iucv%d", id);
dev_set_drvdata(priv->dev, priv);
priv->dev->bus = &iucv_bus;
priv->dev->parent = iucv_root;
priv->dev->groups = hvc_iucv_dev_attr_groups;
priv->dev->release = hvc_iucv_free;
rc = device_register(priv->dev); rc = device_register(priv->dev);
if (rc) { if (rc) {
put_device(priv->dev); put_device(priv->dev);