iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[NETFILTER]: Fix rcu race in ipt_REDIRECT

Browse Source 
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Patrick McHardy 2005-09-13 13:48:58 -07:00 committed by David S. Miller
parent e7fa1bd93f
commit cd0bf2d796
1 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
net/ipv4/netfilter/ipt_REDIRECT.c
View File

@ -88,14 +88,18 @@ redirect_target(struct sk_buff **pskb,
newdst = htonl(0x7F000001); newdst = htonl(0x7F000001);
else { else {
struct in_device *indev; struct in_device *indev;
struct in_ifaddr *ifa;
/* Device might not have an associated in_device. */ newdst = 0;
indev = (struct in_device *)(*pskb)->dev->ip_ptr;
if (indev == NULL || indev->ifa_list == NULL) rcu_read_lock();
indev = __in_dev_get((*pskb)->dev);
if (indev && (ifa = indev->ifa_list))
newdst = ifa->ifa_local;
rcu_read_unlock();
if (!newdst)
return NF_DROP; return NF_DROP;
/* Grab first address on interface. */
newdst = indev->ifa_list->ifa_local;
} }
/* Transfer from original range. */ /* Transfer from original range. */