iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

drivers/tty: remove redundant assignment to variable i and rename it to ret

Browse Source 
The variable i is being assigned a value that is never read
and it is being updated later with a new value. The assignment
is redundant and can be removed.  Also rename i to ret as this new
name makes makes more sense.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Jiri Slaby <jslaby@suse.cz>
Link: https://lore.kernel.org/r/20200405135423.383466-1-colin.king@canonical.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Colin Ian King
2020-04-05 14:54:23 +01:00
committed by Greg Kroah-Hartman
parent 810bc0a5fa
commit cd9479a167
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/tty/serial/8250/serial_cs.c
View File

@@ -440,7 +440,7 @@ static int simple_config_check_notpicky(struct pcmcia_device *p_dev,
static int simple_config(struct pcmcia_device *link) static int simple_config(struct pcmcia_device *link)
{ {
struct serial_info *info = link->priv; struct serial_info *info = link->priv;
int i = -ENODEV, try; int ret, try;
/* /*
* First pass: look for a config entry that looks normal. * First pass: look for a config entry that looks normal.
@@ -472,8 +472,8 @@ found_port:
if (info->quirk && info->quirk->config) if (info->quirk && info->quirk->config)
info->quirk->config(link); info->quirk->config(link);
i = pcmcia_enable_device(link); ret = pcmcia_enable_device(link);
if (i != 0) if (ret != 0)
return -1; return -1;
return setup_serial(link, info, link->resource[0]->start, link->irq); return setup_serial(link, info, link->resource[0]->start, link->irq);
} }