iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

genetlink: Fix a memory leak on error path

Browse Source 
In genl_register_family(), when idr_alloc() fails,
we forget to free the memory we possibly allocate for
family->attrbuf.

Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 2ae0f17df1 ("genetlink: use idr to track families")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Kirill Tkhai <ktkhai@virtuozzo.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
YueHaibing 2019-03-21 15:02:50 +08:00 committed by David S. Miller
parent 33872d79f5
commit ceabee6c59
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
net/netlink/genetlink.c
View File

@ -366,7 +366,7 @@ int genl_register_family(struct genl_family *family)
start, end + 1, GFP_KERNEL); start, end + 1, GFP_KERNEL);
if (family->id < 0) { if (family->id < 0) {
err = family->id; err = family->id;
goto errout_locked; goto errout_free;
} }
err = genl_validate_assign_mc_groups(family); err = genl_validate_assign_mc_groups(family);
@ -385,6 +385,7 @@ int genl_register_family(struct genl_family *family)
errout_remove: errout_remove:
idr_remove(&genl_fam_idr, family->id); idr_remove(&genl_fam_idr, family->id);
errout_free:
kfree(family->attrbuf); kfree(family->attrbuf);
errout_locked: errout_locked:
genl_unlock_all(); genl_unlock_all();