iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

rxrpc: rxkad: Don't use pskb_pull() to advance through the response packet

Browse Source 
In the rxkad security class, don't use pskb_pull() to advance through the
contents of the response packet.  There's no point, especially as the next
and last access to the skbuff still has to allow for the wire header in the
offset (which we didn't advance over).

Better to just add the displacement to the next offset.

Signed-off-by: David Howells <dhowells@redhat.com>
This commit is contained in:
David Howells 2020-09-29 21:48:50 +01:00
parent 521bb3049c
commit ceff522db2
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
net/rxrpc/rxkad.c
View File

@ -1162,8 +1162,6 @@ static int rxkad_verify_response(struct rxrpc_connection *conn,
if (skb_copy_bits(skb, sizeof(struct rxrpc_wire_header), if (skb_copy_bits(skb, sizeof(struct rxrpc_wire_header),
response, sizeof(*response)) < 0) response, sizeof(*response)) < 0)
goto protocol_error; goto protocol_error;
if (!pskb_pull(skb, sizeof(*response)))
BUG();
version = ntohl(response->version); version = ntohl(response->version);
ticket_len = ntohl(response->ticket_len); ticket_len = ntohl(response->ticket_len);
@ -1194,7 +1192,7 @@ static int rxkad_verify_response(struct rxrpc_connection *conn,
eproto = tracepoint_string("rxkad_tkt_short"); eproto = tracepoint_string("rxkad_tkt_short");
abort_code = RXKADPACKETSHORT; abort_code = RXKADPACKETSHORT;
if (skb_copy_bits(skb, sizeof(struct rxrpc_wire_header), if (skb_copy_bits(skb, sizeof(struct rxrpc_wire_header) + sizeof(*response),
ticket, ticket_len) < 0) ticket, ticket_len) < 0)
goto protocol_error_free; goto protocol_error_free;