iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

USB: mos7720: always disable uart on close

Browse Source 
Always try to disable the uart on close.

Since the switch to tty ports, close will be called as part of shutdown
before disconnect returns. Hence there is no need to check the
disconnected flag, and we can put devices in disabled states also on
driver unbind.

Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Johan Hovold 2013-03-21 12:37:41 +01:00 committed by Greg Kroah-Hartman
parent 5813f281bb
commit cf41aa9e19
1 changed files with 3 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/usb/serial/mos7720.c
View File

@ -1140,16 +1140,9 @@ static void mos7720_close(struct usb_serial_port *port)
usb_kill_urb(port->write_urb);
usb_kill_urb(port->read_urb);
mutex_lock(&serial->disc_mutex);
/* these commands must not be issued if the device has
* been disconnected */
if (!serial->disconnected) {
write_mos_reg(serial, port->number - port->serial->minor,
MCR, 0x00);
write_mos_reg(serial, port->number - port->serial->minor,
IER, 0x00);
}
mutex_unlock(&serial->disc_mutex);
write_mos_reg(serial, port->number - port->serial->minor, MCR, 0x00);
write_mos_reg(serial, port->number - port->serial->minor, IER, 0x00);
mos7720_port->open = 0;
}