iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

trace/pid_list: Change gfp flags in pid_list_fill_irq()

Browse Source 
commit 7dc836187f7c6f70a82b4521503e9f9f96194581 upstream.

pid_list_fill_irq() runs via irq_work.
When CONFIG_PREEMPT_RT is disabled, it would run in irq_context.
so it shouldn't sleep while memory allocation.

Change gfp flags from GFP_KERNEL to GFP_NOWAIT to prevent sleep in
irq_work.

This change wouldn't impact functionality in practice because the worst-size
is 2K.

Cc: stable@goodmis.org
Fixes: 8d6e90983ade2 ("tracing: Create a sparse bitmask for pid filtering")
Link: https://lore.kernel.org/20240704150226.1359936-1-yeoreum.yun@arm.com
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Signed-off-by: levi.yun <yeoreum.yun@arm.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
levi.yun 2024-07-04 16:02:26 +01:00 committed by Greg Kroah-Hartman
parent c2ed4dd5e3
commit cf4a37d14c
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
kernel/trace/pid_list.c
View File

@ -354,7 +354,7 @@ static void pid_list_refill_irq(struct irq_work *iwork)
while (upper_count-- > 0) { while (upper_count-- > 0) {
union upper_chunk *chunk; union upper_chunk *chunk;
chunk = kzalloc(sizeof(*chunk), GFP_KERNEL); chunk = kzalloc(sizeof(*chunk), GFP_NOWAIT);
if (!chunk) if (!chunk)
break; break;
*upper_next = chunk; *upper_next = chunk;
@ -365,7 +365,7 @@ static void pid_list_refill_irq(struct irq_work *iwork)
while (lower_count-- > 0) { while (lower_count-- > 0) {
union lower_chunk *chunk; union lower_chunk *chunk;
chunk = kzalloc(sizeof(*chunk), GFP_KERNEL); chunk = kzalloc(sizeof(*chunk), GFP_NOWAIT);
if (!chunk) if (!chunk)
break; break;
*lower_next = chunk; *lower_next = chunk;