iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

habanalabs: change the write flag name of error info structs

Browse Source 
positive flags naming will make more clear code while adding
more 'error info' structures

Signed-off-by: Tal Cohen <talcohen@habana.ai>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
This commit is contained in:
Tal Cohen 2022-06-01 11:32:35 +03:00 committed by Oded Gabbay
parent 939ed076ea
commit d0c92afc0e
4 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/misc/habanalabs/common/command_submission.c
View File

@ -735,8 +735,8 @@ static void cs_timedout(struct work_struct *work)
hdev = cs->ctx->hdev;
/* Save only the first CS timeout parameters */
rc = atomic_cmpxchg(&hdev->last_error.cs_timeout.write_disable, 0, 1);
if (!rc) {
rc = atomic_cmpxchg(&hdev->last_error.cs_timeout.write_enable, 1, 0);
if (rc) {
hdev->last_error.cs_timeout.timestamp = ktime_get();
hdev->last_error.cs_timeout.seq = cs->sequence;
}

12
drivers/misc/habanalabs/common/habanalabs.h
View File

@ -2570,21 +2570,21 @@ struct hl_clk_throttle {
/**
* struct cs_timeout_info - info of last CS timeout occurred.
* @timestamp: CS timeout timestamp.
* @write_disable: if set writing to CS parameters in the structure is disabled so,
* the first (root cause) CS timeout will not be overwritten.
* @write_enable: if set writing to CS parameters in the structure is enabled. otherwise - disabled,
* so the first (root cause) CS timeout will not be overwritten.
* @seq: CS timeout sequence number.
*/
struct cs_timeout_info {
ktime_t timestamp;
atomic_t write_disable;
atomic_t write_enable;
u64 seq;
};
/**
* struct razwi_info - info about last razwi error occurred.
* @timestamp: razwi timestamp.
* @write_disable: if set writing to razwi parameters in the structure is disabled so the
* first (root cause) razwi will not be overwritten.
* @write_enable: if set writing to razwi parameters in the structure is enabled.
* otherwise - disabled, so the first (root cause) razwi will not be overwritten.
* @addr: address that caused razwi.
* @engine_id_1: engine id of the razwi initiator, if it was initiated by engine that does
* not have engine id it will be set to U16_MAX.
@ -2596,7 +2596,7 @@ struct cs_timeout_info {
*/
struct razwi_info {
ktime_t timestamp;
atomic_t write_disable;
atomic_t write_enable;
u64 addr;
u16 engine_id_1;
u16 engine_id_2;

4
drivers/misc/habanalabs/common/habanalabs_drv.c
View File

@ -195,8 +195,8 @@ int hl_device_open(struct inode *inode, struct file *filp)
hl_debugfs_add_file(hpriv);
atomic_set(&hdev->last_error.cs_timeout.write_disable, 0);
atomic_set(&hdev->last_error.razwi.write_disable, 0);
atomic_set(&hdev->last_error.cs_timeout.write_enable, 1);
atomic_set(&hdev->last_error.razwi.write_enable, 1);
hdev->open_counter++;
hdev->last_successful_open_jif = jiffies;

4
drivers/misc/habanalabs/gaudi/gaudi.c
View File

@ -7410,8 +7410,8 @@ static void gaudi_print_irq_info(struct hl_device *hdev, u16 event_type,
gaudi_print_and_get_mmu_error_info(hdev, &razwi_addr, &razwi_type);
/* In case it's the first razwi, save its parameters*/
rc = atomic_cmpxchg(&hdev->last_error.razwi.write_disable, 0, 1);
if (!rc) {
rc = atomic_cmpxchg(&hdev->last_error.razwi.write_enable, 1, 0);
if (rc) {
hdev->last_error.razwi.timestamp = ktime_get();
hdev->last_error.razwi.addr = razwi_addr;
hdev->last_error.razwi.engine_id_1 = engine_id_1;