sbus: bbc_i2c: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Andreas Larsson <andreas@gaisler.com> Signed-off-by: Andreas Larsson <andreas@gaisler.com> Link: https://lore.kernel.org/r/a5ba9d930451d1eeabc4208cc6c75184a92a248d.1709591118.git.u.kleine-koenig@pengutronix.de
This commit is contained in:
parent
61fc8d4067
commit
d0e71777f7
@ -382,7 +382,7 @@ static int bbc_i2c_probe(struct platform_device *op)
|
||||
return err;
|
||||
}
|
||||
|
||||
static int bbc_i2c_remove(struct platform_device *op)
|
||||
static void bbc_i2c_remove(struct platform_device *op)
|
||||
{
|
||||
struct bbc_i2c_bus *bp = dev_get_drvdata(&op->dev);
|
||||
|
||||
@ -396,8 +396,6 @@ static int bbc_i2c_remove(struct platform_device *op)
|
||||
of_iounmap(&op->resource[1], bp->i2c_control_regs, 2);
|
||||
|
||||
kfree(bp);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
static const struct of_device_id bbc_i2c_match[] = {
|
||||
@ -415,7 +413,7 @@ static struct platform_driver bbc_i2c_driver = {
|
||||
.of_match_table = bbc_i2c_match,
|
||||
},
|
||||
.probe = bbc_i2c_probe,
|
||||
.remove = bbc_i2c_remove,
|
||||
.remove_new = bbc_i2c_remove,
|
||||
};
|
||||
|
||||
module_platform_driver(bbc_i2c_driver);
|
||||
|
Loading…
x
Reference in New Issue
Block a user