iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fs/direct-io.c: adjust suspicious bit operation

Browse Source 
READ is 0, so the result of the bit-and operation is 0.  Rewrite with == as
done elsewhere in the same file.

This problem was found using Coccinelle (http://coccinelle.lip6.fr/).

Signed-off-by: Julia Lawall <julia@diku.dk>
Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
Julia Lawall 2012-06-07 15:45:00 -07:00 committed by Al Viro
parent 3dd847820d
commit d187663ef2
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
fs/direct-io.c
View File

@ -1258,7 +1258,7 @@ do_blockdev_direct_IO(int rw, struct kiocb *iocb, struct inode *inode,
*/ */
BUG_ON(retval == -EIOCBQUEUED); BUG_ON(retval == -EIOCBQUEUED);
if (dio->is_async && retval == 0 && dio->result && if (dio->is_async && retval == 0 && dio->result &&
((rw & READ) || (dio->result == sdio.size))) ((rw == READ) || (dio->result == sdio.size)))
retval = -EIOCBQUEUED; retval = -EIOCBQUEUED;
if (retval != -EIOCBQUEUED) if (retval != -EIOCBQUEUED)