net: Remove dev_err() usage after platform_get_irq()
We don't need dev_err() messages when platform_get_irq() fails now that platform_get_irq() prints an error message itself when something goes wrong. Let's remove these prints with a simple semantic patch. // <smpl> @@ expression ret; struct platform_device *E; @@ ret = ( platform_get_irq(E, ...) | platform_get_irq_byname(E, ...) ); if ( \( ret < 0 \| ret <= 0 \) ) { ( -if (ret != -EPROBE_DEFER) -{ ... -dev_err(...); -... } | ... -dev_err(...); ) ... } // </smpl> While we're here, remove braces on if statements that only have one statement (manually). Cc: "David S. Miller" <davem@davemloft.net> Cc: Kalle Valo <kvalo@codeaurora.org> Cc: Saeed Mahameed <saeedm@mellanox.com> Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com> Cc: Felix Fietkau <nbd@nbd.name> Cc: Lorenzo Bianconi <lorenzo@kernel.org> Cc: netdev@vger.kernel.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Stephen Boyd <swboyd@chromium.org> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
committed by
David S. Miller
parent
2d73a6c38d
commit
d1a55841ab
@ -199,10 +199,8 @@ static int bgmac_probe(struct platform_device *pdev)
|
||||
dev_warn(&pdev->dev, "MAC address not present in device tree\n");
|
||||
|
||||
bgmac->irq = platform_get_irq(pdev, 0);
|
||||
if (bgmac->irq < 0) {
|
||||
dev_err(&pdev->dev, "Unable to obtain IRQ\n");
|
||||
if (bgmac->irq < 0)
|
||||
return bgmac->irq;
|
||||
}
|
||||
|
||||
regs = platform_get_resource_byname(pdev, IORESOURCE_MEM, "amac_base");
|
||||
if (!regs) {
|
||||
|
Reference in New Issue
Block a user