iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

efi_test: get rid of pointless access_ok()

Browse Source 
really, people - get_user(), copy_from_user(), memdup_user(), etc.
all fail if access_ok() does.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
Al Viro 2020-04-22 23:02:16 -04:00
parent a38547d435
commit d2659e583e
1 changed files with 0 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/firmware/efi/test/efi_test.c
View File

@ -70,9 +70,6 @@ copy_ucs2_from_user_len(efi_char16_t **dst, efi_char16_t __user *src,
return 0; return 0;
} }
if (!access_ok(src, 1))
return -EFAULT;
buf = memdup_user(src, len); buf = memdup_user(src, len);
if (IS_ERR(buf)) { if (IS_ERR(buf)) {
*dst = NULL; *dst = NULL;
@ -91,9 +88,6 @@ copy_ucs2_from_user_len(efi_char16_t **dst, efi_char16_t __user *src,
static inline int static inline int
get_ucs2_strsize_from_user(efi_char16_t __user *src, size_t *len) get_ucs2_strsize_from_user(efi_char16_t __user *src, size_t *len)
{ {
if (!access_ok(src, 1))
return -EFAULT;
*len = user_ucs2_strsize(src); *len = user_ucs2_strsize(src);
if (*len == 0) if (*len == 0)
return -EFAULT; return -EFAULT;
@ -118,9 +112,6 @@ copy_ucs2_from_user(efi_char16_t **dst, efi_char16_t __user *src)
{ {
size_t len; size_t len;
if (!access_ok(src, 1))
return -EFAULT;
len = user_ucs2_strsize(src); len = user_ucs2_strsize(src);
if (len == 0) if (len == 0)
return -EFAULT; return -EFAULT;
@ -142,9 +133,6 @@ copy_ucs2_to_user_len(efi_char16_t __user *dst, efi_char16_t *src, size_t len)
if (!src) if (!src)
return 0; return 0;
if (!access_ok(dst, 1))
return -EFAULT;
return copy_to_user(dst, src, len); return copy_to_user(dst, src, len);
} }