iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ALSA: hda/analog - Sink ad198x_shutup() and shuffle CONFIG_PM guards

Browse Source 
When CONFIG_PM is not set, there is an unused function warning:

sound/pci/hda/patch_analog.c:115:13: warning: unused function
'ad198x_shutup' [-Wunused-function]
static void ad198x_shutup(struct hda_codec *codec)
            ^
1 warning generated.

Sink ad198x_shutup() into ad198x_suspend(), as it is only called in that
one space. Move the CONFIG_PM guards above ad198x_power_eapd_write() as
it is only called in ad198x_power_eapd(), which is in turn only called
in ad198x_power_eapd(). Those two functions are large enough that they
are left alone.

Fixes: 327b34f2a97d ("ALSA: hda: Nuke unused reboot_notify callback")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Link: https://lore.kernel.org/r/20210818012705.311963-2-nathan@kernel.org
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Nathan Chancellor 2021-08-17 18:27:05 -07:00 committed by Takashi Iwai
parent f8b32a6daf
commit d2d8375637
1 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
sound/pci/hda/patch_analog.c
View File

@ -72,7 +72,7 @@ static int create_beep_ctls(struct hda_codec *codec)
#define create_beep_ctls(codec) 0 #define create_beep_ctls(codec) 0
#endif #endif
#ifdef CONFIG_PM
static void ad198x_power_eapd_write(struct hda_codec *codec, hda_nid_t front, static void ad198x_power_eapd_write(struct hda_codec *codec, hda_nid_t front,
hda_nid_t hp) hda_nid_t hp)
{ {
@ -112,16 +112,10 @@ static void ad198x_power_eapd(struct hda_codec *codec)
} }
} }
static void ad198x_shutup(struct hda_codec *codec) static int ad198x_suspend(struct hda_codec *codec)
{ {
snd_hda_shutup_pins(codec); snd_hda_shutup_pins(codec);
ad198x_power_eapd(codec); ad198x_power_eapd(codec);
}
#ifdef CONFIG_PM
static int ad198x_suspend(struct hda_codec *codec)
{
ad198x_shutup(codec);
return 0; return 0;
} }
#endif #endif