iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

media: coda: split marking last meta into helper function

Browse Source 
Split marking the last metadata entry into a helper function to simplify
coda_decoder_cmd.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
This commit is contained in:
Philipp Zabel 2020-03-18 19:35:34 +01:00 committed by Mauro Carvalho Chehab
parent 12310819a2
commit d2f1db8608
1 changed files with 22 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
drivers/media/platform/coda/coda-common.c
View File

@ -1153,6 +1153,26 @@ static int coda_try_decoder_cmd(struct file *file, void *fh,
return v4l2_m2m_ioctl_try_decoder_cmd(file, fh, dc);
}
static bool coda_mark_last_meta(struct coda_ctx *ctx)
{
struct coda_buffer_meta *meta;
coda_dbg(1, ctx, "marking last meta\n");
spin_lock(&ctx->buffer_meta_lock);
if (list_empty(&ctx->buffer_meta_list)) {
spin_unlock(&ctx->buffer_meta_lock);
return false;
}
meta = list_last_entry(&ctx->buffer_meta_list, struct coda_buffer_meta,
list);
meta->last = true;
spin_unlock(&ctx->buffer_meta_lock);
return true;
}
static int coda_decoder_cmd(struct file *file, void *fh,
struct v4l2_decoder_cmd *dc)
{
@ -1197,22 +1217,10 @@ static int coda_decoder_cmd(struct file *file, void *fh,
stream_end = true;
}
} else {
coda_dbg(1, ctx, "marking last meta\n");
/* Mark last meta */
spin_lock(&ctx->buffer_meta_lock);
if (!list_empty(&ctx->buffer_meta_list)) {
struct coda_buffer_meta *meta;
meta = list_last_entry(&ctx->buffer_meta_list,
struct coda_buffer_meta,
list);
meta->last = true;
if (coda_mark_last_meta(ctx))
stream_end = true;
} else {
else
wakeup = true;
}
spin_unlock(&ctx->buffer_meta_lock);
}
if (stream_end) {