iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

NFC: Removed addressed shdlc TODOs

Browse Source 
The questions asked in the comments have been answered and addressed.

Signed-off-by: Eric Lapuyade <eric.lapuyade@intel.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
This commit is contained in:
Eric Lapuyade 2012-05-03 14:53:20 +02:00 committed by John W. Linville
parent a9a741a7e2
commit d3b4044531
1 changed files with 0 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
net/nfc/hci/shdlc.c
View File

@ -340,15 +340,6 @@ static void nfc_shdlc_connect_complete(struct nfc_shdlc *shdlc, int r)
shdlc->state = SHDLC_CONNECTED;
} else {
shdlc->state = SHDLC_DISCONNECTED;
/*
* TODO: Could it be possible that there are pending
* executing commands that are waiting for connect to complete
* before they can be carried? As connect is a blocking
* operation, it would require that the userspace process can
* send commands on the same device from a second thread before
* the device is up. I don't think that is possible, is it?
*/
}
shdlc->connect_result = r;
@ -926,8 +917,6 @@ void nfc_shdlc_free(struct nfc_shdlc *shdlc)
{
pr_debug("\n");
/* TODO: Check that this cannot be called while still in use */
nfc_hci_unregister_device(shdlc->hdev);
nfc_hci_free_device(shdlc->hdev);