iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fpga: Fix dead store in fpga-bridge.c

Browse Source 
Using clang's scan-build/view this issue was flagged
a dead store issue in fpga-bridge.c

warning: Value stored to 'ret' is never read [deadcode.DeadStores]
                  ret = id;

Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: Moritz Fischer <mdf@kernel.org>
This commit is contained in:
Tom Rix 2020-06-08 05:54:46 -07:00 committed by Moritz Fischer
parent 88aaab9218
commit d3fbd739fc
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/fpga/fpga-bridge.c
View File

@ -328,7 +328,7 @@ struct fpga_bridge *fpga_bridge_create(struct device *dev, const char *name,
void *priv) void *priv)
{ {
struct fpga_bridge *bridge; struct fpga_bridge *bridge;
int id, ret = 0; int id, ret;
if (!name || !strlen(name)) { if (!name || !strlen(name)) {
dev_err(dev, "Attempt to register with no name!\n"); dev_err(dev, "Attempt to register with no name!\n");
@ -340,10 +340,8 @@ struct fpga_bridge *fpga_bridge_create(struct device *dev, const char *name,
return NULL; return NULL;
id = ida_simple_get(&fpga_bridge_ida, 0, 0, GFP_KERNEL); id = ida_simple_get(&fpga_bridge_ida, 0, 0, GFP_KERNEL);
if (id < 0) { if (id < 0)
ret = id;
goto error_kfree; goto error_kfree;
}
mutex_init(&bridge->mutex); mutex_init(&bridge->mutex);
INIT_LIST_HEAD(&bridge->node); INIT_LIST_HEAD(&bridge->node);