iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

opp: Don't ignore clk_get() errors other than -ENOENT

Browse Source 
Not all devices that need to use OPP core need to have clocks, a missing
clock is fine in which case -ENOENT shall be returned by clk_get().

Anything else is an error and must be handled properly.

Reported-by: Dmitry Osipenko <digetx@gmail.com>
Tested-by: Dmitry Osipenko <digetx@gmail.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
This commit is contained in:
Viresh Kumar 2021-01-29 16:12:04 +05:30
parent 870d5d9639
commit d4a4c7a411
1 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
drivers/opp/core.c
View File

@ -1252,6 +1252,8 @@ static struct opp_table *_update_opp_table_clk(struct device *dev,
struct opp_table *opp_table,
bool getclk)
{
int ret;
/*
* Return early if we don't need to get clk or we have already tried it
* earlier.
@ -1261,18 +1263,20 @@ static struct opp_table *_update_opp_table_clk(struct device *dev,
/* Find clk for the device */
opp_table->clk = clk_get(dev, NULL);
if (IS_ERR(opp_table->clk)) {
int ret = PTR_ERR(opp_table->clk);
if (ret == -EPROBE_DEFER) {
dev_pm_opp_put_opp_table(opp_table);
return ERR_PTR(ret);
}
ret = PTR_ERR_OR_ZERO(opp_table->clk);
if (!ret)
return opp_table;
if (ret == -ENOENT) {
dev_dbg(dev, "%s: Couldn't find clock: %d\n", __func__, ret);
return opp_table;
}
return opp_table;
dev_pm_opp_put_opp_table(opp_table);
dev_err_probe(dev, ret, "Couldn't find clock\n");
return ERR_PTR(ret);
}
/*