iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

usb: chipidea: ci_hdrc_imx: fix potential error pointer dereference in probe

Browse Source 
If the first call to devm_usb_get_phy_by_phandle(dev, "fsl,usbphy", 0)
fails with something other than -ENODEV then it leads to an error
pointer dereference.  For those errors we should just jump directly to
the error handling.

Fixes: 8253a34bfae3 ("usb: chipidea: ci_hdrc_imx: Also search for 'phys' phandle")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20211117074923.GF5237@kili
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Dan Carpenter 2021-11-17 10:49:23 +03:00 committed by Greg Kroah-Hartman
parent 6ae6dc22d2
commit d4d2e5329a
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
drivers/usb/chipidea/ci_hdrc_imx.c
View File

@ -420,15 +420,15 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev)
data->phy = devm_usb_get_phy_by_phandle(dev, "fsl,usbphy", 0); data->phy = devm_usb_get_phy_by_phandle(dev, "fsl,usbphy", 0);
if (IS_ERR(data->phy)) { if (IS_ERR(data->phy)) {
ret = PTR_ERR(data->phy); ret = PTR_ERR(data->phy);
if (ret == -ENODEV) { if (ret != -ENODEV)
data->phy = devm_usb_get_phy_by_phandle(dev, "phys", 0); goto err_clk;
if (IS_ERR(data->phy)) { data->phy = devm_usb_get_phy_by_phandle(dev, "phys", 0);
ret = PTR_ERR(data->phy); if (IS_ERR(data->phy)) {
if (ret == -ENODEV) ret = PTR_ERR(data->phy);
data->phy = NULL; if (ret == -ENODEV)
else data->phy = NULL;
goto err_clk; else
} goto err_clk;
} }
} }