iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

xen/pciback: Check PF instead of VF for PCI_COMMAND_MEMORY

Browse Source 
commit 8d47065f7d upstream.

Commit 408fb0e5aa (xen/pciback: Don't
allow MSI-X ops if PCI_COMMAND_MEMORY is not set) prevented enabling
MSI-X on passed-through virtual functions, because it checked the VF
for PCI_COMMAND_MEMORY but this is not a valid bit for VFs.

Instead, check the physical function for PCI_COMMAND_MEMORY.

Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: David Vrabel <david.vrabel@citrix.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Konrad Rzeszutek Wilk
2016-02-11 16:10:23 -05:00
committed by Greg Kroah-Hartman
parent e32b123fee
commit d52a248196
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/xen/xen-pciback/pciback_ops.c
View File

@ -227,8 +227,9 @@ int xen_pcibk_enable_msix(struct xen_pcibk_device *pdev,
/* /*
* PCI_COMMAND_MEMORY must be enabled, otherwise we may not be able * PCI_COMMAND_MEMORY must be enabled, otherwise we may not be able
* to access the BARs where the MSI-X entries reside. * to access the BARs where the MSI-X entries reside.
* But VF devices are unique in which the PF needs to be checked.
*/ */
pci_read_config_word(dev, PCI_COMMAND, &cmd); pci_read_config_word(pci_physfn(dev), PCI_COMMAND, &cmd);
if (dev->msi_enabled || !(cmd & PCI_COMMAND_MEMORY)) if (dev->msi_enabled || !(cmd & PCI_COMMAND_MEMORY))
return -ENXIO; return -ENXIO;