iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

pinctrl: xway: Use devm_kasprintf() instead of fixed buffer formatting

Browse Source 
Improve readability and maintainability by replacing a hardcoded string
allocation and formatting by the use of the devm_kasprintf() helper.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20190731132917.17607-4-geert+renesas@glider.be
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Geert Uytterhoeven 2019-07-31 15:29:17 +02:00 committed by Linus Walleij
parent 811604d01e
commit d55b7fdd58
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/pinctrl/pinctrl-xway.c
View File

@ -1731,13 +1731,11 @@ static int pinmux_xway_probe(struct platform_device *pdev)
return -ENOMEM; return -ENOMEM;
for (i = 0; i < xway_chip.ngpio; i++) { for (i = 0; i < xway_chip.ngpio; i++) {
/* strlen("ioXY") + 1 = 5 */ char *name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "io%d", i);
char *name = devm_kzalloc(&pdev->dev, 5, GFP_KERNEL);
if (!name) if (!name)
return -ENOMEM; return -ENOMEM;
snprintf(name, 5, "io%d", i);
xway_info.pads[i].number = GPIO0 + i; xway_info.pads[i].number = GPIO0 + i;
xway_info.pads[i].name = name; xway_info.pads[i].name = name;
} }