iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Input: aiptek - fix endpoint sanity check

Browse Source 
commit 3111491fca4f01764e0c158c5e0f7ced808eef51 upstream.

The driver was checking the number of endpoints of the first alternate
setting instead of the current one, something which could lead to the
driver binding to an invalid interface.

This in turn could cause the driver to misbehave or trigger a WARN() in
usb_submit_urb() that kernels with panic_on_warn set would choke on.

Fixes: 8e20cf2bce12 ("Input: aiptek - fix crash on detecting device without endpoints")
Signed-off-by: Johan Hovold <johan@kernel.org>
Acked-by: Vladis Dronov <vdronov@redhat.com>
Link: https://lore.kernel.org/r/20191210113737.4016-3-johan@kernel.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Johan Hovold 2020-01-10 11:59:32 -08:00 committed by Greg Kroah-Hartman
parent 20ae16280a
commit d6ca8b03fd
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/input/tablet/aiptek.c
View File

@ -1815,14 +1815,14 @@ aiptek_probe(struct usb_interface *intf, const struct usb_device_id *id)
input_set_abs_params(inputdev, ABS_WHEEL, AIPTEK_WHEEL_MIN, AIPTEK_WHEEL_MAX - 1, 0, 0); input_set_abs_params(inputdev, ABS_WHEEL, AIPTEK_WHEEL_MIN, AIPTEK_WHEEL_MAX - 1, 0, 0);
/* Verify that a device really has an endpoint */ /* Verify that a device really has an endpoint */
if (intf->altsetting[0].desc.bNumEndpoints < 1) { if (intf->cur_altsetting->desc.bNumEndpoints < 1) {
dev_err(&intf->dev, dev_err(&intf->dev,
"interface has %d endpoints, but must have minimum 1\n", "interface has %d endpoints, but must have minimum 1\n",
intf->altsetting[0].desc.bNumEndpoints); intf->cur_altsetting->desc.bNumEndpoints);
err = -EINVAL; err = -EINVAL;
goto fail3; goto fail3;
} }
endpoint = &intf->altsetting[0].endpoint[0].desc; endpoint = &intf->cur_altsetting->endpoint[0].desc;
/* Go set up our URB, which is called when the tablet receives /* Go set up our URB, which is called when the tablet receives
* input. * input.