iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

of/fdt: declared return type does not match actual return type

Browse Source 
[ Upstream commit 7913145afa ]

The commit 649cab56de (“of: properly check for error returned
by fdt_get_name()”) changed the return value type from bool to int,
but forgot to change the return value simultaneously.

populate_node was only called in unflatten_dt_nodes, and returns
with values greater than or equal to 0 were discarded without further
processing. Considering that return 0 usually indicates success,
return 0 instead of return true.

Fixes: 649cab56de (“of: properly check for error returned by fdt_get_name()”)
Signed-off-by: Xu Qiang <xuqiang36@huawei.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20220801120506.11461-2-xuqiang36@huawei.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Xu Qiang
2022-08-01 12:05:06 +00:00
committed by Greg Kroah-Hartman
parent 4ef616730a
commit d6d4b5f13b
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/of/fdt.c
View File

@ -246,7 +246,7 @@ static int populate_node(const void *blob,
} }
*pnp = np; *pnp = np;
return true; return 0;
} }
static void reverse_nodes(struct device_node *parent) static void reverse_nodes(struct device_node *parent)