iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tools lib traceevent: Fix get_field_str() for dynamic strings

Browse Source 
If a field is a dynamic string, get_field_str() returned just the
offset/size value and not the string. Have it parse the offset/size
correctly to return the actual string. Otherwise filtering fails when
trying to filter fields that are dynamic strings.

Reported-by: Gopanapalli Pradeep <prap_hai@yahoo.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Link: http://lkml.kernel.org/r/20180112004823.146333275@goodmis.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Steven Rostedt (VMware) 2018-01-11 19:47:51 -05:00 committed by Arnaldo Carvalho de Melo
parent 806efaed3c
commit d777f8de99
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tools/lib/traceevent/parse-filter.c
View File

@ -1877,17 +1877,25 @@ static const char *get_field_str(struct filter_arg *arg, struct pevent_record *r
struct pevent *pevent; struct pevent *pevent;
unsigned long long addr; unsigned long long addr;
const char *val = NULL; const char *val = NULL;
unsigned int size;
char hex[64]; char hex[64];
/* If the field is not a string convert it */ /* If the field is not a string convert it */
if (arg->str.field->flags & FIELD_IS_STRING) { if (arg->str.field->flags & FIELD_IS_STRING) {
val = record->data + arg->str.field->offset; val = record->data + arg->str.field->offset;
size = arg->str.field->size;
if (arg->str.field->flags & FIELD_IS_DYNAMIC) {
addr = *(unsigned int *)val;
val = record->data + (addr & 0xffff);
size = addr >> 16;
}
/* /*
* We need to copy the data since we can't be sure the field * We need to copy the data since we can't be sure the field
* is null terminated. * is null terminated.
*/ */
if (*(val + arg->str.field->size - 1)) { if (*(val + size - 1)) {
/* copy it */ /* copy it */
memcpy(arg->str.buffer, val, arg->str.field->size); memcpy(arg->str.buffer, val, arg->str.field->size);
/* the buffer is already NULL terminated */ /* the buffer is already NULL terminated */