iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

staging: lustre: ldlm: free resource when ldlm_lock_create() fails.

Browse Source 
ldlm_lock_create() gets a resource, but don't put it on
all failure paths. It should.

Signed-off-by: NeilBrown <neilb@suse.com>
Reviewed-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
NeilBrown 2018-03-29 15:26:48 +11:00 committed by Greg Kroah-Hartman
parent aa4cc28e4d
commit d8caf662b4
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/staging/lustre/lustre/ldlm/ldlm_lock.c
View File

@ -1551,8 +1551,10 @@ struct ldlm_lock *ldlm_lock_create(struct ldlm_namespace *ns,
return ERR_CAST(res); return ERR_CAST(res);
lock = ldlm_lock_new(res); lock = ldlm_lock_new(res);
if (!lock) if (!lock) {
ldlm_resource_putref(res);
return ERR_PTR(-ENOMEM); return ERR_PTR(-ENOMEM);
}
lock->l_req_mode = mode; lock->l_req_mode = mode;
lock->l_ast_data = data; lock->l_ast_data = data;
@ -1595,6 +1597,8 @@ out:
return ERR_PTR(rc); return ERR_PTR(rc);
} }
/** /**
* Enqueue (request) a lock. * Enqueue (request) a lock.
* On the client this is called from ldlm_cli_enqueue_fini * On the client this is called from ldlm_cli_enqueue_fini