iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

xen-netback: Fix pointer incrementation to avoid incorrect logging

Browse Source 
Due to this pointer is increased prematurely, the error log contains rubbish.

Signed-off-by: Zoltan Kiss <zoltan.kiss@citrix.com>
Reported-by: Armin Zentai <armin.zentai@ezit.hu>
Cc: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: xen-devel@lists.xenproject.org
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Zoltan Kiss 2014-07-18 19:08:05 +01:00 committed by David S. Miller
parent 1b860da040
commit d8cfbfc466
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/xen-netback/netback.c
View File

@ -1045,7 +1045,6 @@ static int xenvif_tx_check_gop(struct xenvif_queue *queue,
/* Check status of header. */ /* Check status of header. */
err = (*gopp_copy)->status; err = (*gopp_copy)->status;
(*gopp_copy)++;
if (unlikely(err)) { if (unlikely(err)) {
if (net_ratelimit()) if (net_ratelimit())
netdev_dbg(queue->vif->dev, netdev_dbg(queue->vif->dev,
@ -1058,6 +1057,7 @@ static int xenvif_tx_check_gop(struct xenvif_queue *queue,
xenvif_idx_release(queue, pending_idx, xenvif_idx_release(queue, pending_idx,
XEN_NETIF_RSP_ERROR); XEN_NETIF_RSP_ERROR);
} }
(*gopp_copy)++;
check_frags: check_frags:
for (i = 0; i < nr_frags; i++, gop_map++) { for (i = 0; i < nr_frags; i++, gop_map++) {