staging: wilc1000: Fix memleak in wilc_bus_probe
When devm_clk_get() returns -EPROBE_DEFER, spi_priv should be freed just like when wilc_cfg80211_init() fails. Fixes: 854d66df74aed ("staging: wilc1000: look for rtc_clk clock in spi mode") Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> Link: https://lore.kernel.org/r/20200819115426.29852-1-dinghao.liu@zju.edu.cn Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
39b3666821
commit
d8eb176d97
@ -112,9 +112,10 @@ static int wilc_bus_probe(struct spi_device *spi)
|
||||
wilc->dev_irq_num = spi->irq;
|
||||
|
||||
wilc->rtc_clk = devm_clk_get(&spi->dev, "rtc_clk");
|
||||
if (PTR_ERR_OR_ZERO(wilc->rtc_clk) == -EPROBE_DEFER)
|
||||
if (PTR_ERR_OR_ZERO(wilc->rtc_clk) == -EPROBE_DEFER) {
|
||||
kfree(spi_priv);
|
||||
return -EPROBE_DEFER;
|
||||
else if (!IS_ERR(wilc->rtc_clk))
|
||||
} else if (!IS_ERR(wilc->rtc_clk))
|
||||
clk_prepare_enable(wilc->rtc_clk);
|
||||
|
||||
return 0;
|
||||
|
Loading…
x
Reference in New Issue
Block a user